Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strategy docs updates #8711

Merged
merged 26 commits into from
Dec 11, 2024
Merged

Strategy docs updates #8711

merged 26 commits into from
Dec 11, 2024

Conversation

melindafekete
Copy link
Collaborator

@melindafekete melindafekete commented Nov 11, 2024 •
edited
Loading

Key changes:

For an engineer review, please take a look at :

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:49pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:49pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@melindafekete melindafekete marked this pull request as ready for review December 5, 2024 11:39
@melindafekete melindafekete force-pushed the melinda/strategy-docs-update branch from 79e9ad2 to ffae788 Compare December 6, 2024 15:52
gastonfournier
gastonfournier reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I didn't get to review website/docs/reference/unleash-context.md and left a few minor comments, happy to approve it though, just ping me

README.md Outdated Show resolved Hide resolved
website/docs/reference/activation-strategies.md Show resolved Hide resolved
website/docs/reference/activation-strategies.md Outdated Show resolved Hide resolved
website/docs/reference/activation-strategies.md Show resolved Hide resolved
website/docs/reference/activation-strategies.md Outdated Show resolved Hide resolved
website/docs/reference/activation-strategies.md Outdated Show resolved Hide resolved
website/docs/reference/activation-strategies.md Outdated Show resolved Hide resolved
website/docs/reference/strategy-variants.mdx Outdated Show resolved Hide resolved
nnennandukwe
nnennandukwe approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@nnennandukwe nnennandukwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in this PR looks like all past references to old strategy variants and constraints URLs have been updated. reviewed it last week but hadn't hit approve. looks good to me

@melindafekete
Copy link
Collaborator Author

Looks good, I didn't get to review website/docs/reference/unleash-context.md and left a few minor comments, happy to approve it though, just ping me

Thanks @gastonfournier addressed all the outstanding suggestions in 455aa4b

gastonfournier
gastonfournier approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙌

@melindafekete melindafekete merged commit 311df82 into main Dec 11, 2024
14 checks passed
@melindafekete melindafekete deleted the melinda/strategy-docs-update branch December 11, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnennandukwe nnennandukwe nnennandukwe approved these changes

@gastonfournier gastonfournier gastonfournier approved these changes

Assignees

@melindafekete melindafekete

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melindafekete @gastonfournier @nnennandukwe